8000 Fix ROCm device visibility in CI by upsj · Pull Request #744 · ginkgo-project/ginkgo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix ROCm device visibility in CI #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

upsj
Copy link
Member
@upsj upsj commented Apr 15, 2021

This is an attempt to fix the random issues with hidden GPUs due to CUDA_VISIBLE_DEVICES being interpreted by ROCm as well.

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Apr 15, 2021
@upsj upsj self-assigned this Apr 15, 2021
@ginkgo-bot ginkgo-bot added the reg:ci-cd This is related to the continuous integration system. label Apr 15, 2021
@yhmtsai
Copy link
Member
yhmtsai commented Apr 15, 2021

does gitlab ci variable allow RANDOM?
By the way, it is fixed in #737 by different implementation

@upsj
Copy link
Member Author
upsj commented Apr 15, 2021

@yhmtsai yes, looks like it doesn't work. I had hoped this would be simple text replacement, but looks like gitlab does something more complex there.

@upsj upsj closed this Apr 15, 2021
@upsj upsj deleted the rocm_visible_devices branch April 15, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-for-review This PR is ready for review reg:ci-cd This is related to the continuous integration system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0