8000 Update fsharp-analyzers and the analyzer packages by Numpsy · Pull Request #662 · giraffe-fsharp/Giraffe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update fsharp-analyzers and the analyzer packages #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

Numpsy
Copy link
Contributor
@Numpsy Numpsy commented Jun 13, 2025

refs #660 (comment) - update the analyzer packages and the analyzers cli tool in one go to keep the versions in step

Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the analyzer packages and the analyzer CLI tool versions to keep them in sync.

  • Bumped G-Research.FSharp.Analyzers from version 0.14.0 to 0.15.0
  • Bumped Ionide.Analyzers from version 0.14.2 to 0.14.5 in the project file
  • Updated fsharp-analyzers CLI tool version from 0.29.1 to 0.31.0 in the dotnet-tools configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Giraffe/Giraffe.fsproj Updated analyzer package versions for consistency
.config/dotnet-tools.json Upgraded the CLI tool version to match the package updates
Comments suppressed due to low confidence (3)

src/Giraffe/Giraffe.fsproj:58

  • Ensure that the updated version of G-Research.FSharp.Analyzers is fully compatible with the project’s analyzer configuration and build process.
    <PackageReference Include="G-Research.FSharp.Analyzers" Version="0.15.0">

src/Giraffe/Giraffe.fsproj:62

  • Verify that the Ionide.Analyzers update to version 0.14.5 aligns with the overall analyzer configuration and does not introduce any unexpected warnings.
    <PackageReference Include="Ionide.Analyzers" Version="0.14.5">

.config/dotnet-tools.json:12

  • Confirm that the fsharp-analyzers CLI tool upgrade to version 0.31.0 is compatible with the new analyzer package versions and does not disrupt CLI operations.
      "version": "0.31.0",

@64J0 64J0 added the dependencies Pull requests that update a dependency file label Jun 16, 2025
@64J0 64J0 self-requested a review June 16, 2025 18:48
Copy link
Member
@64J0 64J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Numpsy, the CI is working properly with this change!

@64J0 64J0 merged commit 33be1c3 into giraffe-fsharp:master Jun 16, 2025
6 checks passed
@64J0 64J0 added .NET Pull requests that update .net code labels Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0