10000 Fix collapsing commit history by tjomson · Pull Request #665 · git-truck/git-truck · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix collapsing commit history #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2023
Merged

Fix collapsing commit history #665

merged 2 commits into from
Nov 5, 2023

Conversation

tjomson
Copy link
Contributor
@tjomson tjomson commented Nov 5, 2023

Fixes #664
Fixes #661

@tjomson tjomson requested review from nimrossum and dawidwoz November 5, 2023 09:56
@codecov Codecov
Copy link
codecov bot commented Nov 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a97f63e) 59.52% compared to head (9fb59fd) 59.52%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   59.52%   59.52%           
=======================================
  Files           2        2           
  Lines          42       42           
  Branches        7        7           
=======================================
  Hits           25       25           
  Misses         16       16           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nimrossum
nimrossum requested changes Nov 5, 2023
View reviewed changes
Copy link
Contributor
@nimrossum nimrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs a little change.

nimrossum
nimrossum approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor
@nimrossum nimrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjomson tjomson merged commit cf157b9 into main Nov 5, 2023
@tjomson tjomson deleted the fix-fold-collapse-chevron-for-commit-history branch November 5, 2023 11:25
@nimrossum nimrossum removed the request for review from dawidwoz November 5, 2023 12:19
@dawidwoz
Copy link
Member
dawidwoz commented Nov 7, 2023

@joglr @tjomson Good catch! Everything works smoothly now. Thank you for fixing it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimrossum nimrossum nimrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking "+ X day(s) more" does not affect fold down arrow Reword to "+X more day(s)"
3 participants
@tjomson @dawidwoz @nimrossum
0