8000 Differentiate authors by color in "single author" visualization by tjomson · Pull Request #702 · git-truck/git-truck · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Differentiate authors by color in "single author" visualization #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2023
Merged

Differentiate authors by color in "single author" visualization #702

merged 4 commits into from
Nov 22, 2023

Conversation

tjomson
Copy link
Contributor
@tjomson tjomson commented Nov 21, 2023

Resolves #574

@tjomson
Differentiate authors by color in "single author" visualization
< 8000 div class="pr-1 d-md-inline-block d-none">
fc26b5c 
Fixes #574
@nimrossum nimrossum self-requested a review November 21, 2023 23:49
nimrossum
nimrossum approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor
@nimrossum nimrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement!

@nimrossum nimrossum enabled auto-merge (squash) November 21, 2023 23:50
nimrossum
nimrossum requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor
@nimrossum nimrossum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the author color visible in the author distribution in the details panel as well for the single author view?Screenshot_20231122-005054.png

As seen when Top contributor is selected:
Screenshot_20231122-005203.png

@tjomson
Copy link
Contributor Author
tjomson commented Nov 22, 2023

Can you make the author color visible in the author distribution in the details panel as well for the single author view?!

Yes. I think the author color should be in details no matter which color metric is selected

@nimrossum
Copy link
Contributor

Can you make the author color visible in the author distribution in the details panel as well for the single author view?!

Yes. I think the author color should be in details no matter which color metric is selected

Good idea, this also encourage us to use the author colors more broadly and will custom the user to see each person as the color!

@tjomson tjomson requested a review from nimrossum November 22, 2023 08:54
nimrossum
nimrossum approved these changes Nov 22, 2023
View reviewed changes
@nimrossum nimrossum merged commit 397423f into main Nov 22, 2023
@nimrossum nimrossum deleted the 574/Differentiate-authors-by-color-in-single-author-visualization branch November 22, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimrossum nimrossum nimrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Differentiate authors by color in "single author" visualization
2 participants
@tjomson @nimrossum
0