8000 Migrate to @duckdb/node-api by nimrossum · Pull Request #769 · git-truck/git-truck · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate to @duckdb/node-api #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 10, 2025
Merged

Migrate to @duckdb/node-api #769

merged 17 commits into from
Feb 10, 2025

Conversation

nimrossum
Copy link
Contributor
@nimrossum nimrossum commented Feb 3, 2025

Replace duckdb-async with @duckdb/node-api in package.json

  • Make sure Linux etc. is still able to be analyzed (stress test)
  • Consider using appendChunk and refreshing connections
  • Refactor places that use addRows to call duckdb methods directly

Copy link
codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cf157b9) to head (6d6c0b3).
Report is 73 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##             main      #769       +/-   ##
============================================
+ Coverage   59.52%   100.00%   +40.47%     
============================================
  Files           2         1        -1     
  Lines          42         9       -33     
  Branches        7         0        -7     
============================================
- Hits           25         9       -16     
+ Misses         16         0       -16     
+ Partials        1         0        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimrossum nimrossum enabled auto-merge (squash) February 3, 2025 15:29
@nimrossum nimrossum requested a review from tjomson February 3, 2025 15:29
@nimrossum nimrossum disabled auto-merge February 10, 2025 20:16
@nimrossum nimrossum merged commit 02bdbbf into main Feb 10, 2025
12 checks passed
@nimrossum nimrossum deleted the duckdb-neo branch February 10, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0