8000 Meson CI fixes by pks-t · Pull Request #1952 · git/git · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Meson CI fixes #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Meson CI fixes #1952

wants to merge 2 commits into from
+1 −0

Conversation

pks-t
Copy link
Contributor
@pks-t pks-t commented May 5, 2025

Test PR.

@gitgitgadget-git GitGitGadget-Git
Copy link

There are issues in commit b71b29d:
slimdown and trigger
Commit checks stopped - the message is too short
Commit not signed off

1 similar comment
< 8000 a class="d-inline-block" href="/apps/gitgitgadget-git">@gitgitgadget-git GitGitGadget-Git
Copy link

There are issues in commit b71b29d:
slimdown and trigger
Commit checks stopped - the message is too short
Commit not signed off

@gitgitgadget-git GitGitGadget-Git
Copy link

There are issues in commit eee3b31:
x
Commit checks stopped - the message is too short
Commit not signed off

pks-t added 2 commits May 5, 2025 11:32
@pks-t
ci: fix aggregation of test results with Meson
69362f7 
Hi,

Johannes reported to me off-list that aggregation of test results
doesn't work on GitHub Workflow when using Meson, as can be seen e.g. in
[1].

As it turns out, the issue is that we don't set `TEST_OUTPUT_DIRECTORY`
for many of the GitHub Workflows jobs. And because Meson by default puts
test results into the build instead of into the source directory our
assumption that the results can be found in "t/" is broken. This isn't 

I never noticed this failure myself because in GitLab we always set the
above environment variable there. In any case, this patch fixes it as
can be seen at [2].

Thanks!

Patrick

[1]: https://github.com/git-for-windows/git/actions/runs/14806194960/job/41574766327#step:9:2125
[2]: https://github.com/git/git/actions/runs/14833082023/job/41638408968

--- b4-submit-tracking ---
# This section is used internally by b4 prep for tracking purposes.
{
  "series": {
    "revision": 1,
    "change-id": "20250505-b4-pks-meson-aggregate-results-60ef175dd424",
    "prefixes": []
  }
}
@pks-t
ci: fix aggregation of test results with Meson
c1896e5 
Our CI needs to be aware of the location of the test output directory so
that it knows where to find test results. Some of our CI jobs achieve
this by setting the `TEST_OUTPUT_DIRECTORY` environment variable, which
ensures that the output will be written to that directory. Other jobs,
especially on GitHub Workflows, don't set that environment variable and
instead expect test results to be located in the source directory in
"t/".

The latter logic does not work with Meson though, as the test results
are not written into the source directory by default, but instead into
the build directory. As such, any job that uses Meson without setting
the environment variable will be unable to locate and aggregate results.

Fix this by explicitly setting the test output directory when we set up
the Meson build directory. Like this, we can easily default to "t/" in
the source directory when the value hasn't been set explicitly.

Reported-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
@pks-t pks-t force-pushed the b4/pks-meson-aggregate-results branch from eee3b31 to c1896e5 Compare May 5, 2025 09:37
@gitgitgadget-git GitGitGadget-Git
Copy link

There are issues in commit 69362f7:
ci: fix aggregation of test results with Meson
Commit not signed off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pks-t
0