Enable SMS Verification directly from Trust Bonus tab #7456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates the Trust Bonus tab such that SMS verification can be done directly on the page * Create a Vue component by extracting all relevant SMS code from the cart page * Tie the new component to the Trust Bonus tab and display it when the user clicks the verify button
octavioamu
suggested changes
Sep 17, 2020
|
|
||
| if (document.getElementById('gc-sms-modal')) { | ||
|
|
||
| const app = new Vue({ |
There was a problem hiding this comment.
can we do something like const appTrust here? I want to avoid coalitions with others apps loaded on the same page.
octavioamu
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of kicking users over to the cart to verify their SMS, they can now do it directly from the Trust Bonus tab.
Note: This PR extracts and modifies code from the cart to create a vue component used on the Trust Bonus tab. The component is NOT currently shared with the cart, but should be, to DRY things up. This needed refactoring is noted in TODO comments, and should be tackled post Round 7.