Make computed properties reactive to document.web3network changes #7473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I also added a commit to add SNT support here since that was recently added by zkSync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The list of supported zkSync tokens is stored as a computed property called
zkSyncSupportedTokens. It's dependent ondocument.web3network. Vue cannot react to changes indocument, so when the network changed this was not updated.This means if a user visits the cart, then connects their wallet, the network change would not be detected, and
zkSyncSupportedTokenswould return an empty list. As a result, they would not be able to checkout with zkSync.Solution
We fix this by adding a new property to the component. Vue can watch and react to changes in this new property, and we update this new property when the
dataWalletReadyevent is detected. We also make the mainnet token list the default when nothing is detectedcc @octavioamu @thelostone-mc