8000 fix: update QR code for CELO + cUSD by thelostone-mc · Pull Request #7824 · gitcoinco/web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: update QR code for CELO + cUSD #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix: update QR code for CELO + cUSD #7824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/assets/v2/js/pages/bounty_details2.js
View file
Open in desktop
BC68
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,11 @@ Vue.mixin({
`ethereum:${address}`;
break;

case 'CELO': // waiting : pending
case 'CELO':
case 'cUSD':
qr_string = value ?
`celo://wallet/pay?address=${address}&amount=${value}` :
`celo://wallet/pay?address=${address}`;
`celo://wallet/pay?address=${address}&amount=${value}&token=${token_name}` :
`celo://wallet/pay?address=${address}&token=${token_name}`;
Copy link
@medhakothari medhakothari Nov 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to clarify, if the token param is not given, the deeplink will default to cUSD, so you can choose whether or not you want to provide it in your deeplink. For CELO though, the param is necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! thanks for clarifying that @medhak1

break;

case 'ZIL':
Expand Down
0