8000 GITC-98: Update libs to the latest and best versions by octavioamu · Pull Request #9210 · gitcoinco/web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

GITC-98: Update libs to the latest and best versions #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2021

Conversation

octavioamu
Copy link
Contributor
@octavioamu octavioamu commented Jun 25, 2021
Description

This PR is part of the performance improvements tasks.
Update web3modal wallets libs to the improved ones.
Portis (this one changed it approach and no longer block loading)
Formatic
also:
web3modal
walletconnect

Portis old behaviour
loads the template and expensive resources even when not in use or active
image

Refers/Fixes

Close https://gitcoin.atlassian.net/browse/GITC-98

Testing

tested connections to all the wallets with new versions.

@thelostone-mc thelostone-mc merged commit e921e00 into master Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0