8000 1/Test CartActivity model by jeremyschuurmans · Pull Request #9392 · gitcoinco/web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

1/Test CartActivity model #9392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeremyschuurmans
Copy link
Description

This PR adds unit tests to CartActivity

Refers/Fixes
Testing

@jeremyschuurmans jeremyschuurmans changed the title Test cart activity model Test CartActivity model Aug 26, 2021
@jeremyschuurmans jeremyschuurmans marked this pull request as draft September 15, 2021 19:31
@jeremyschuurmans jeremyschuurmans changed the title Test CartActivity model WIP: 1/Test CartActivity model Sep 15, 2021
@jeremyschuurmans jeremyschuurmans changed the base branch from add-grants-unit-tests to master September 16, 2021 15:39
pytest-isort==2.0.0
pytest-factoryboy==2.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ this seems to be duplicate entry

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thelostone-mc Nice catch. I'll fix that

@jeremyschuurmans jeremyschuurmans changed the base branch from master to add-grants-unit-tests September 16, 2021 15:44
@jeremyschuurmans jeremyschuurmans changed the base branch from add-grants-unit-tests to master September 16, 2021 22:25
@jeremyschuurmans jeremyschuurmans changed the base branch from master to add-grants-unit-tests September 16, 2021 22:27
@jeremyschuurmans jeremyschuurmans force-pushed the test-cart-activity-model branch 2 times, most recently from 3a32048 to 84949db Compare September 17, 2021 21:06
@jeremyschuurmans jeremyschuurmans marked this pull request as ready for review September 17, 2021 21:07
@jeremyschuurmans jeremyschuurmans changed the title WIP: 1/Test CartActivity model 1/Test CartActivity model Sep 17, 2021
@jeremyschuurmans jeremyschuurmans force-pushed the add-grants-unit-tests branch 2 times, most recently from 69bb98a to 81f1318 Compare September 22, 2021 18:35
@jeremyschuurmans jeremyschuurmans changed the base branch from add-grants-unit-tests to master September 27, 2021 20:16
Jeremy Schuurmans added 6 commits September 27, 2021 15:16
* create new directory for models, copy over Contribution model

* extract grants models to individual files

* rename relocated_models directory, remove original models directory, add imports, resolve circular dependencies

* extract CLRMatch into separate file

* extract Flag into separate file

* extract MatchPledge to separate file

* extract Donation and PhantomFunding

* extract GrantStat into separate file

* refactor

* extract GrantBrandingRoutingPolicy to separate file

* update migration

* add missing import to MatchPledge, remove imports from __init__.py

* add missing import

* decouple GrantCLRCalculation and move to own file

* extract GrantType to own file

* extract GrantCLR to own file

* add missing import

* refactor, add missing imports

* remove whitespace

* resolve circular dependency

* run 'make fix'

* import changes from gitcoinco#9314

* add try/except to migration file instead of editing migration directly

* refactor
@thelostone-mc thelostone-mc merged commit f83724f into gitcoinco:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0