-
Notifications
You must be signed in to change notification settings - Fork 83k
Add HIP.gitignore #4663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add HIP.gitignore #4663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new HIP.gitignore template for AMD HIP (ROCm) projects. It aims to provide an up-to-date ignore file that covers build directories, generated files, IDE settings, and tutorial outputs while avoiding overly broad ignore rules.
- Introduces a dedicated HIP.gitignore file based on the official AMD ROCm HIP guidelines.
- Excludes build artifacts, intermediate files, and IDE/editor-specific settings.
- Ensures sample source files remain tracked while generated files and logs are ignored.
@Young-TW could you please strip this down to be very HIP focused? We try not to throw everything into our templates and instead make them very specific to the language or technology in question. |
Thanks for the review. I’ve removed all OS- and editor-specific rules, leaving only HIP/ROCm build artifacts and sample outputs. Please let me know if any further tweaks are needed! |
I’ve rebased onto upstream/main to remove the merge commit and then force-pushed (--force-with-lease). The branch history is now linear — please let me know if you’d like any further adjustments. |
Reasons for making this change
.gitignore
for AMD HIP (ROCm) that covers both the upstream ROCm/hip repo’s own ignores and the most common host‐build workflows (CMake, Ninja, Meson).*
) that would inadvertently ignore user dotfiles like.clang-format
,.github/
,.env
, etc..vscode/
,.idea/
) and common intermediate artifacts without cluttering the templateLinks to documentation supporting these rule changes
.gitignore
in upstream repo:https://github.com/ROCm/hip/blob/amd-staging/.gitignore
https://rocm.docs.amd.com/projects/HIP/en/latest/index.html
.gitignore
templates:https://github.com/github/gitignore#what-makes-a-good-template
If this is a new template
Link to application or project’s homepage:
https://github.com/ROCm/hip
Merge and Approval Steps