8000 Add HIP.gitignore by Young-TW · Pull Request #4663 · github/gitignore · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add HIP.gitignore #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add HIP.gitignore #4663

wants to merge 2 commits into from

Conversation

Young-TW
Copy link

Reasons for making this change

  • Provide an official, up-to-date .gitignore for AMD HIP (ROCm) that covers both the upstream ROCm/hip repo’s own ignores and the most common host‐build workflows (CMake, Ninja, Meson)
  • Avoid overbroad rules (e.g. .*) that would inadvertently ignore user dotfiles like .clang-format, .github/, .env, etc.
  • Include IDE/editor directories (.vscode/, .idea/) and common intermediate artifacts without cluttering the template
  • Ensure that tutorial/sample source files remain tracked, while only their generated binaries and logs are ignored

Links to documentation supporting these rule changes

If this is a new template

Link to application or project’s homepage:
https://github.com/ROCm/hip

Merge and Approval Steps

  • Confirm that you've read the contribution guidelines and ensured your PR aligns
  • Ensure CI is passing
  • Get a review and approval from one of the maintainers

@Copilot Copilot AI review requested due to automatic review settings June 11, 2025 07:56
@Young-TW Young-TW requested a review from a team as a code owner June 11, 2025 07:56
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new HIP.gitignore template for AMD HIP (ROCm) projects. It aims to provide an up-to-date ignore file that covers build directories, generated files, IDE settings, and tutorial outputs while avoiding overly broad ignore rules.

  • Introduces a dedicated HIP.gitignore file based on the official AMD ROCm HIP guidelines.
  • Excludes build artifacts, intermediate files, and IDE/editor-specific settings.
  • Ensures sample source files remain tracked while generated files and logs are ignored.

@wirecat
Copy link
Collaborator
wirecat commented Jun 13, 2025

@Young-TW could you please strip this down to be very HIP focused? We try not to throw everything into our templates and instead make them very specific to the language or technology in question.

@Young-TW
Copy link
Author

Thanks for the review. I’ve removed all OS- and editor-specific rules, leaving only HIP/ROCm build artifacts and sample outputs. Please let me know if any further tweaks are needed!

@Young-TW
Copy link
Author

I’ve rebased onto upstream/main to remove the merge commit and then force-pushed (--force-with-lease). The branch history is now linear — please let me know if you’d like any further adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0