8000 Detect base64 secrets with generic-api-key by rgmz · Pull Request #1598 · gitleaks/gitleaks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Detect base64 secrets with generic-api-key #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

Detect base64 secrets with generic-api-key #1598

merged 1 commit into from
Jan 22, 2025

Conversation

rgmz
Copy link
Contributor
@rgmz rgmz commented Oct 23, 2024

Description:

This fixes an inconsistency where a baes64 encoded secret value (such as abdcefg==) would be detected, but other ones with valid characters + and / weren't.

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@rgmz rgmz force-pushed the feat/generic-base65 branch from 13bed16 to 82ba5ab Compare October 23, 2024 21:48
@rgmz rgmz force-pushed the feat/generic-base65 branch from 82ba5ab to 542da31 Compare December 5, 2024 23:35
@rgmz rgmz force-pushed the feat/generic-base65 branch 2 times, most recently from 309be2e to 6da5942 Compare January 15, 2025 13:04
@rgmz rgmz force-pushed the feat/generic-base65 branch 2 times, most recently from 7d38bbf to 386cb2d Compare January 22, 2025 14:44
zricethezav
zricethezav reviewed Jan 22, 2025
View reviewed changes
@rgmz rgmz force-pushed the feat/generic-base65 branch 2 times, most recently from 35edb57 to ba8fc53 Compare January 22, 2025 14:54
@rgmz rgmz force-pushed the feat/generic-base65 branch from ba8fc53 to 21f88ba Compare January 22, 2025 15:00
@zricethezav zricethezav merged commit f3ae52e into gitleaks:master Jan 22, 2025
1 check passed
@rgmz rgmz deleted the feat/generic-base65 branch January 22, 2025 15:29
@pvillaverde pvillaverde mentioned this pull request Jan 25, 2025
Open
alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
@rgmz
feat(generic-api-key): detect base64 (gitleaks#1598)
759cb3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgmz @zricethezav
0