8000 Minor false positive improvements by rgmz · Pull Request #1758 · gitleaks/gitleaks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Minor false positive improvements #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2025
Merged

Minor false positive improvements #1758

merged 4 commits into from
Feb 19, 2025

Conversation

rgmz
Copy link
Contributor
@rgmz rgmz commented Feb 16, 2025

Description:

This tweaks the patterns/allowlist for a couple rules to reduce issues.

  • generic-api-key: Add keyPress to the allowlist for
  • private-key: require a minimum length of 64 between start and end, don't detect empty/nonsense matches
  • sentry-org-token: fix intermittent generate issue
  • base config: ignore findings that are obviously just file paths

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

rgmz added 4 commits February 16, 2025 12:05
@rgmz
feat(generic): add 'keypress' to allowlist
ec2a1eb
@rgmz
feat(privatekey): ignore empty/impossible matches
19121a0
@rgmz
feat(config): ignore 'secrets' that are file paths
55d5be5
@rgmz
fix(sentry): handle special character at end
43dcb1a 
Prevent common test error of 'Failed to Validate. True positive was not detected by regex.' because the generated value didn't play nicely with word boundary.
@rgmz rgmz force-pushed the feat/improve-allowlists branch from 1198b52 to 43dcb1a Compare February 16, 2025 17:28
@zricethezav zricethezav merged commit 3fa5a3a into gitleaks:master Feb 19, 2025
1 check passed
@rgmz rgmz deleted the feat/improve-allowlists branch February 19, 2025 14:17
@rgmz rgmz mentioned this pull request Mar 24, 2025
Closed
alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
@rgmz
Minor false positive improvements (gitleaks#1758)
f86dd44 
* feat(generic): add 'keypress' to allowlist

* feat(privatekey): ignore empty/impossible matches

* feat(config): ignore 'secrets' that are file paths

* fix(sentry): handle special character at end
Prevent common test error of 'Failed to Validate. True positive was not detected by regex.' because the generated value didn't play nicely with word boundary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgmz @zricethezav
0