8000 newline literal by zricethezav · Pull Request #1718 · gitleaks/gitleaks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

newline literal #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025
Merged

newline literal #1718

merged 1 commit into from
Jan 21, 2025

Conversation

zricethezav
Copy link
Collaborator

Description:

Fixes #1710

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@zricethezav zricethezav merged commit 52b895a into master Jan 21, 2025
3 checks passed
@zricethezav zricethezav deleted the literal-newline branch January 21, 2025 03:37
@rgmz rgmz mentioned this pull request Jan 21, 2025
3 tasks
@@ -28,7 +28,7 @@ const (
// boundaries for the secret
secretPrefixUnique = `\b(`
secretPrefix = `[\x60'"\s=]{0,5}(`
secretSuffix = `)(?:[\x60'"\s;]|$)`
secretSuffix = `)(?:[\x60'"\s;\\n]|$)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight mistake: this will match \\ or n separately. I created #1719 to address this.

alayne222 pushed a commit to alayne222/gitleaks that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secrets that end with a literal \n aren't detected
2 participants
0