8000 Test fixes and documentation updates by pat-s · Pull Request #190 · giuseppec/iml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test fixes and documentation updates #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2022
Merged

Test fixes and documentation updates #190

merged 5 commits into from
Apr 25, 2022

Conversation

pat-s
Copy link
Collaborator
@pat-s pat-s commented Apr 25, 2022

@christophM

Some small test fixes:

  • data.table now wants to have bit64 to be installed
  • Silenced a warning complaining about a too large k value in a test
  • Fixed a failed test because the underlying expectation wording did not match anymore

In addition the roxygen template grid.points was missing entirely and for some reason not caught before. I've added it now and roxygenized again. The content was taken from existing content of a man/ file.

@christophM
Copy link
Collaborator

Thanks a lot Patrick.
MacOS-latest fails, but I had that also in another repo. Seems connected to failure to install qpdf, so unrelated to your PR.

@codecov-commenter
Copy link

Codecov Report

Merging #190 (d5cff8c) into main (3f79d36) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   90.04%   89.92%   -0.12%     
==========================================
  Files          17       17              
  Lines        1668     1668              
==========================================
- Hits         1502     1500       -2     
- Misses        166      168       +2     
Impacted Files Coverage Δ
R/LocalModel.R 95.23% <0.00%> (-2.39%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@christophM christophM merged commit d707fe0 into main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0