Abstract output dtype #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gonmeso
previously approved these changes
Mar 18, 2024
| print(f"ONNX model saved at: {save_path}") | ||
| self.session = ort.InferenceSession(save_path) | ||
| print("Model ready for inference with ONNX Runtime! ✅") | ||
| print(f"ONNX model saved at: {save_path} ✅") |
There was a problem hiding this comment.
Note to self:
- add logging instead of just printing
- add debug logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the process for users by automatically determining the output data type of a Cairo model, eliminating the need for manual specification.
This is achieved by identifying the operator type (op_type) responsible for the graph's output. In cases where the op_type corresponds to an "exceptional" operator, the operator's data type is used. Otherwise, the default output type is set to
Tensor<FP16x16>.