8000 fix: full width clickable link for monitor-site by ralphocdol · Pull Request #405 · glanceapp/glance · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: full width clickable link for monitor-site #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2025
Merged

fix: full width clickable link for monitor-site #405

merged 3 commits into from
Mar 10, 2025

Conversation

ralphocdol
Copy link
Contributor
@ralphocdol ralphocdol commented Mar 10, 2025 •
edited
Loading

I always find myself clicking a blank canvas next to the actual link, this just aims to expand the clickable area

The screenshot is just to show where the clickable part is.
Before:
Screenshot_20250310_164158

After:
Screenshot_20250310_164225

This is more noticeable on mobile mode. Have to click across with just a right hand.

@ralphocdol ralphocdol changed the title feat: full width clickable link for monitor-site fix: full width clickable link for monitor-site Mar 10, 2025
svilenmarkov
svilenmarkov approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member
@svilenmarkov svilenmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

I changed the implementation to use flex-grow: 1 instead of width: 100% since min-width: 0 is required for the text truncation to work.

@svilenmarkov svilenmarkov merged commit e373eee into glanceapp:dev Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svilenmarkov svilenmarkov svilenmarkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralphocdol @svilenmarkov
0