update error reporting for custom-api JSON validation #594
Conversation
- show the request error on non-200 responses
|
We could maybe do this for status codes >= 500 because their meaning is ubiquitous, though I've purposefully left handling the response status codes to the template, since servers can return any 4xx code to signify any kind of meaning, which you'd likely want to be able to handle manually on a per-widget basis. For example a 404 could mean a "this endpoint doesn't exist, the user provided an incorrect path and needs to fix their URL", or it could mean "this resource doesn't exist yet but that's expected behavior" and the template can conditionally show data from that endpoint or not. |
|
I may have read/followed the code incorrectly. It seemed that if json validation happened at all, and the response wasn't valid JSON. If |
show the request error on non-200 responses