Dynamize manifest.json with configurable options #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svilenmarkov
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Thanks for contributing and making those changes! I've made a bunch of additional tweaks, more importantly parsing and caching the manifest contents only once on application creation rather than parsing on each request, as well as changing how the caching works, since the manifest can change between config reloads, which the staticFSHash wouldn't reflect.
|
Great, thank you! I completely forgot about caching, that makes a ton of sense. Glad this is going to be in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some exciting updates to my original PR! It's now more user-friendly and configurable, and you won't need to ask for the manifest file explicitly anymore.
I noticed that this configuration option wasn't documented or mentioned on the roadmap, so I decided to take the initiative and add it. This change is all about giving users more control over the dashboard icon when saving it to the home screen on Apple/PWA devices. Currently, there’s no option to customize the icon, and I'm excited to share that this update will introduce that possibility!
@svilenmarkov what do you think?