feat: add triggerElementProps to allow passing of props to trigger element #147
Conversation
|
Thanks Matt, this works great. CC @glennflanagan What do you think about throwing a warning/error if a user tries to pass If they do, the collapsible styling + functionality will break because className={triggerClassString.trim()} <TriggerElement
className={triggerClassString.trim()} // - this will be overwrittenWe could do something like this in mount? componentDidMount() {
const { triggerElementProps } = this.props
if (triggerElementProps && triggerElementProps.className) {
console.warn('Cannot pass className to triggerElementProps')
// or explicitly, (People using CRA would have a visual error if they're using the overlay)
throw new Error('Cannot pass className to triggerElementProps')
}
} |
|
@karltaylor if the className is required then we should spread the |
|
We have the prop |
|
To be honest, We already do this here: <ContentContainerElement className={parentClassString.trim()} {...this.props.containerElementProps}>I guess we can leave it to the user to understand not to pass the className into this prop as it will break stuff? |
|
I'm happy to merge 🎉🚀 @MattBodey thanks for creating an itch to work on this over the weekend 👍 😅 |
|
Agreed, this is something that can be avoided by dev config so we don't need to overcomplicate the code even more |
|
Thanks! I think that merging the className would be a good idea, though I hope that by the time someone is injecting custom props they understand what they are doing somewhat 😄 |
This PR fixes #146 by allowing the user to pass a new prop to the component.