10000 Fix building on old gnu/linux systems by WillyJL · Pull Request #2649 · glfw/glfw · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix building on old gnu/linux systems #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix building on old gnu/linux systems #2649

wants to merge 3 commits into from

Conversation

WillyJL
Copy link
@WillyJL WillyJL commented Nov 22, 2024

Fixes #2495:

  • Some files including time.h were not setting _GNU_SOURCE, so builds failed as CLOCK_REALTIME and CLOCK_MONOTONIC were not defined
  • Header linux/input-event-codes.h was added around 2015 to kernel tree, so it is not available in the old systems in question (Building GLFW 3.4 fails on manylinux2014 and manylinux2010 #2495 references manylinux2014)
  • O_CLOEXEC was also undeclared without _GNU_SOURCE defined

@WillyJL WillyJL requested a review from elmindreda as a code owner November 22, 2024 06:01
@WillyJL WillyJL mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmindreda elmindreda Awaiting requested review from elmindreda elmindreda is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building GLFW 3.4 fails on manylinux2014 and manylinux2010
1 participant
@WillyJL
0