8000 Improve init and termination with counting by wintertime · Pull Request #2070 · glfw/glfw · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve init and termination with counting #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump 8000 to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve init and termination with counting #2070

wants to merge 1 commit into from

Conversation

wintertime
Copy link

Counts additional calls to glfwInit and waits with termination until the same
amount of calls to glfwTerminate is done.
For normal users nothing should change.
For libraries/plug-ins they can now call glfwInit and glfwTerminate additional
times as long as the calls are balanced. This avoids the problem that they
would terminate GLFW completely when the main application is still using it.

This should fix the underlying problem of #2036 . It may still be useful to additionally merge #2065 .

@wintertime wintertime requested a review from elmindreda as a code owner April 2, 2022 12:39
@nitrix
Copy link
nitrix commented Jul 28, 2022 •
edited
Loading

Had a small discussion on IRC, logging here for the record.

Essentially, the backwards compatibility of GLFW is quite important and the current state of the PR would affect the behavior for developers that are relying on the multiple init (with the superfluous ones ignored) + single termination.

I proposed a new glfwInitHint(GLFW_REFCOUNTED, true); initialization flag that can be set prior to initialization, after which the rest of the PR can apply -- only conditionally to that flag being set though.

It seems reasonable and I can spend a bit of time on that approach depending on @wintertime's reponsiveness.

CC @elmindreda to confirm the viability of the idea.

@wintertime
Copy link
Author
wintertime commented Jul 30, 2022 •
edited
Loading

Hi,

I saw the first, happy reply in email, but did not get a notification for the completely different edit. It was pure luck I did not find it a month later.

I disagree, adding a hint to conditionally keep the bug (or strange behaviour oversight) would not be a feasible approach:

  • Currently, it would automatically fix the problem with an update, but with the conditional hint it would not.
  • What happens if some caller sets the hint and some other not?
  • For the majority use case of having a single init and single terminate nothing changes regarding compatibility.
  • For the case of an application using init+terminate on demand repeatedly nothing changes, too.
  • For the case of an application having an unknown number of plug-ins (or similar) and both the application and plug-ins needing GLFW, the old code only supports having init done by the application always and the plug-ins relying on it, but avoiding these calls. That would be possible already.
  • If the application would not reliably call init, it would IMHO be a plug-in bug to haphazardly call init itself, because it can not know if it would later be the last one having to call terminate (unless using other unsupported hacks, because until the other MR is merged there is no function to test if initialization was done), therefore it would just never call terminate (as it very likely would break another plug-in to call it early) and leak (nicer told "rely on the OS for cleanup"). If it never calls terminate anyway (or just the application before exit) the change would not influence compatibility.
  • Lastly, I doubt the old code allows to coordinate with the app+multiple plug-ins to externally wrap around a scheme to reliably call terminate always but not too early. So I'd guess, there can be no compatibility problem, too. Or you have examples for this case actually? If yes, I'd think a cmake option would be the way to optionally reactivate the bug.

@wintertime
Improve init and termination with counting
6ea6273 
Counts additional calls to glfwInit and waits with termination until the same
amount of calls to glfwTerminate is done.
For normal users nothing should change.
For libraries/plug-ins they can now call glfwInit and glfwTerminate additional
times as long as the calls are balanced. This avoids the problem that they
would terminate GLFW completely when the main application is still using it.
@nitrix
Copy link
nitrix commented Jul 31, 2022

I prefer the PR as-is, but that'll be a tough sell to @elmindreda.
Either way, I'm offering my help too if there's a clear path forward.

@tlf30 tlf30 mentioned this pull request Sep 15, 2022
Open
@abhi-k9 abhi-k9 mentioned this pull request Feb 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmindreda elmindreda Awaiting requested review from elmindreda elmindreda is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wintertime @nitrix
0