fix: call onCellActivated on typing #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for emitting the onCellActivated event when the user begins typing in a cell.
- Added a new test checking that typing triggers onCellActivated in the DataEditor.
- Updated the implementation in DataEditor and its API documentation to reflect the new behavior.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/test/data-editor.test.tsx | New test ensuring that onCellActivated is called when typing occurs. |
| packages/core/src/docs/examples/cell-activated-event.stories.tsx | Updated examples to document that typing activates the cell. |
| packages/core/src/data-editor/data-editor.tsx | Modified event handling to trigger onCellActivated on typing. |
| packages/core/API.md | Updated documentation to include typing as a trigger for cell activation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1007