Improve and distribute TypeScript typings #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4006986 to
e33fc7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to properly collect and distribute TypeScript typings for some of our distributed modules.
These changes typecheck but fail to run. There are a few issues I still need to figure out:
import * from "./Data.Either"fails to build, whileimport * from "Data.Either"fails to run.I solved this by rewriting the imports in
script/build.sh, relativizing absolute imports in the JavaScript files produced bytsc. I also copy@types/*.d.tsunder the corresponding module directories indist/. This is all surprisingly manual, perhaps we'll find a better way later.