8000 Refactor out import cycles by inferrinizzard · Pull Request #2733 · glideapps/quicktype · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor out import cycles #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, y 10000 ou agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 12, 2025
Merged

Refactor out import cycles #2733

merged 14 commits into from
May 12, 2025

Conversation

inferrinizzard
Copy link
Contributor
@inferrinizzard inferrinizzard commented May 10, 2025 •
edited
Loading

Description

  • Refactored misc files and organised to reduce import cycles
  • TypeGraph -> GraphRebuilding -> TypeBuilder -> TypeGraph resolved with workaround of manually binding typeGraph reference in TypeBuilder instances after constructor

Related Issue

Motivation and Context

Previous Behaviour / Output

stateDiagram-v2
	TypeGraph --> GraphRewriting
	TypeGraph --> Type
	TypeGraph --> TypeBuilder
	GraphRewriting --> TypeBuilder
	TypeBuilder --> Type
	TypeBuilder --> TypeGraph
	TypeBuilder --> StringTypes
	StringTypes --> TypeBuilder
	Type --> TypeGraph
	TypeUtils --> Type
	TypeUtils --> StringTypes

	Description --> JSONSchemaInput
	JSONSchemaInput --> Description
Loading

New Behaviour / Output

stateDiagram-v2
	TypeGraph --> TypeRef
	TypeGraph --> GraphRewriting
	TypeGraph --> TypeGraphUtils
	TypeGraphUtils --> Type
	GraphRewriting --> TypeBuilder
	TypeBuilder --> Type
	TypeBuilder --> StringTypes
	Type --> TypeRef

	Description --> PathElementKind
	JSONSchemaInput --> PathElementKind
Loading

How Has This Been Tested?

Screenshots (if appropriate):

@inferrinizzard inferrinizzard enabled auto-merge (squash) May 12, 2025 01:16
@inferrinizzard inferrinizzard force-pushed the chore/repo/import-cycle branch from 97d2b0a to 5bbfc5a Compare May 12, 2025 01:20
@inferrinizzard inferrinizzard merged commit 7143aee into glideapps:master May 12, 2025
21 checks passed
@inferrinizzard inferrinizzard deleted the chore/repo/import-cycle branch May 12, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to com 5304 ment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@inferrinizzard
0