Fix static_mut_refs warnings
#2127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tests/support/mod.rs: - EVENT_LOOP_PROXY, WINDOW_RECEIVER, INIT_EVENT_LOOP, SEND_PROXY: `mut` is not necessary (anymore?) - initialize_event_loop::<closure>::<closure>::WINDOWS: This is not an elegant solution, and refactoring half of mod.rs is beyond me. As such, just suppress the warning, it is a false positive here anyway.
est31
requested changes
Sep 29, 2024
|
I don't know how to make it work. If I wrap let mut mutex_lock = WINDOWS.lock().unwrap();
let window = &mutex_lock.as_mut().unwrap()[&key];
sender.send((window.into(), gl_config)).unwrap();
// `mutex_lock` dropped here while still borrowed |
|
If I may express my opinion here, I think the use of a global variable here is the core issue. Ideally, the tests should be refactored to eliminate the need for it in the first place. I'm not yet ready to commit myself to this refactor, and I understand that no one else is available. I would then suggest that the awkward and annoying In personal experience, if you want something to be temporary, make it ugly, so it's impossible to forget. |
justincredible
added a commit
to justincredible/glium
that referenced
this pull request
Oct 5, 2024
After the refactoring, this is an immediate consequence of the observation from `glium`glium#2127.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for nightly check warnings discovered in #2126.
Turns out, most of
static mut's are not needed in the first place, and the one that is necessary is a dirty hack regardless.