8000 Replace deprecated scipy.ndimage.fourier namespace with scipy.ndimage. by bdice · Pull Request #911 · glotzerlab/freud · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace deprecated scipy.ndimage.fourier namespace with scipy.ndimage. #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2022
Merged

Replace deprecated scipy.ndimage.fourier namespace with scipy.ndimage. #911

merged 1 commit into from
Feb 7, 2022

Conversation

bdice
Copy link
Member
@bdice bdice commented Feb 6, 2022 •
edited
Loading

Description

The scipy package has adjusted its public namespaces to make names more clear in release 1.8.0. This PR adjusts the one instance I saw in freud's codebase that would raise a DeprecationWarning for scipy >= 1.8.0. I verified that this namespace change is compatible with our minimal requirement of scipy 1.1.0.

Motivation and Context

See: scipy/scipy#14360

How Has This Been Tested?

Existing tests are sufficient.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@bdice bdice self-assigned this Feb 6, 2022
@bdice bdice added the enhancement New feature or request label Feb 6, 2022
@bdice bdice modified the milestones: v2.8.0, v2.9.0 Feb 6, 2022
@bdice bdice marked this pull request as ready for review February 6, 2022 21:31
@bdice bdice requested review from a team and alacour and removed request for a team February 6, 2022 21:31
@codecov
Copy link
codecov bot commented Feb 6, 2022 •
edited
Loading

Codecov Report

Merging #911 (790c697) into master (1854dcd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #911   +/-   ##
=======================================
  Coverage   55.24%   55.24%           
=======================================
  Files          15       15           
  Lines        2576     2576           
  Branches       38       38           
=======================================
  Hits         1423     1423           
  Misses       1137     1137           
  Partials       16       16
Impacted Files Coverage Δ
freud/diffraction.pyx 62.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1854dcd...790c697. Read the comment docs.

alacour
alacour approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor
@alacour alacour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very simple change!

@bdice bdice merged commit 3cbe0f3 into master Feb 7, 2022
@bdice bdice deleted the scipy-1.8.0-deprecations branch February 7, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alacour alacour alacour approved these changes

Assignees

@bdice bdice

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @alacour
0