8000 (S)ponge (A)PI for (F)ield (E)lements Implementation by ozgurarmanc · Pull Request #9 · gnosisguild/greco · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

(S)ponge (A)PI for (F)ield (E)lements Implementation #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 27, 2025
Merged

(S)ponge (A)PI for (F)ield (E)lements Implementation #9

merged 21 commits into from
May 27, 2025

Conversation

ozgurarmanc
Copy link
Member
@ozgurarmanc ozgurarmanc commented May 16, 2025 •
edited
Loading

Description

This PR will implement the SAFE API in Noir. Further details can be found here.

Closes gnosisguild/enclave#360

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or nargo fmt on default settings.

@ozgurarmanc ozgurarmanc self-assigned this May 16, 2025
@ozgurarmanc ozgurarmanc linked an issue May 16, 2025 that may be closed by this pull request
SAFE API implementation for the deterministic random function gnosisguild/enclave#360
Closed
@ozgurarmanc ozgurarmanc requested a review from YounesTal1 May 19, 2025 16:38
@ozgurarmanc ozgurarmanc marked this pull request as ready for review May 20, 2025 11:34
@0xjei
Copy link
Member
0xjei commented May 20, 2025 •
edited
Loading

is this ready for review? @ozgurarmanc - seems yes, moved on the board to Review.

YounesTal1
YounesTal1 reviewed May 22, 2025
View reviewed changes
YounesTal1
YounesTal1 reviewed May 22, 2025
View reviewed changes
YounesTal1
YounesTal1 reviewed May 22, 2025
View reviewed changes
YounesTal1
YounesTal1 reviewed May 22, 2025
View reviewed changes
YounesTal1
YounesTal1 reviewed May 22, 2025
View reviewed changes
YounesTal1
YounesTal1 reviewed May 22, 2025
View reviewed changes
@YounesTal1
Copy link
Member

Also there is no need to generate the files Prover0.toml, and pk_enc_{}{}{}_zeroes.json in this file.

@YounesTal1
Copy link
Member

Also not related to safe API, I think it is safer to generate a different random number for every equation we are checking (this means we need to squeeze two random numbers for each q_i, as we are checking two equations per q_i).
This is because these equations are not completely independent.

8000
0xjei
0xjei reviewed May 23, 2025
View reviewed changes
@ozgurarmanc ozgurarmanc requested a review from YounesTal1 May 23, 2025 14:59
0xjei
0xjei approved these changes May 23, 2025
View reviewed changes
Copy link
Member
@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@0xjei 0xjei mentioned this pull request May 23, 2025
Closed
YounesTal1
YounesTal1 reviewed May 27, 2025
View reviewed changes
@ozgurarmanc ozgurarmanc merged commit c5fc25b into noir May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounesTal1 YounesTal1 YounesTal1 left review comments

@0xjei 0xjei 0xjei approved these changes

Assignees

@ozgurarmanc ozgurarmanc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SAFE API implementation for the deterministic random function
3 participants
@ozgurarmanc @0xjei @YounesTal1
0