v5: plumbing: transport, Reintroduce SetHostKeyCallback. Fix #1514 #1515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR go-git#1482 renamed SetHostKeyCallback to SetHostKeyCallbackAndAlgorithms, due to the change in behaviour. For keeping backwards compatibility within existing v5, a new SetHostKeyCallback is being introduced that simply calls back to SetHostKeyCallbackAndAlgorithms. Some tests were introduced to enforce expected behaviour. Signed-off-by: Paulo Gomes <pjbgf@linux.com>
This was referenced Apr 14, 2025
|
|
||
| // fallback allows for injecting the fallback call, which is called | ||
| // when a HostKeyCallback is not set. | ||
| fallback func(files ...string) (ssh.HostKeyCallback, error) |
There was a problem hiding this comment.
Might be worth indicating that this is only meant for testing, but in practice it always calls NewKnownHostsCallback
There was a problem hiding this comment.
Good point. I was initially considered this, but given that it is already an internal field and the code may not necessarily move into v6, I ended up deciding against it.
hiddeco
approved these changes
Apr 14, 2025
This was referenced Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #1482 renamed
SetHostKeyCallbacktoSetHostKeyCallbackAndAlgorithms, due to the change in behaviour in that method. For keeping backwards compatibility with v5, a newSetHostKeyCallbackis being introduced that simply calls back toSetHostKeyCallbackAndAlgorithms.Some tests were introduced to enforce expected behaviour.