git: repository, add empty dir check to clone #1594
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add check to return early from clone if the destination dir is not empty, remove cleanup logic that removed files from errored clones - git doesn't have this logic, update repository_test to test against new error type
58dc7c0 to
2db07ff
Compare
pjbgf
reviewed
Jul 3, 2025
| func PlainClone(path string, o *CloneOptions) (*Repository, error) { | ||
| return PlainCloneContext(context.Background(), path, o) | ||
| } | ||
|
|
||
| // PlainCloneContext a repository into the path with the given options, isBare | ||
| // defines if the new repository will be bare or normal. If the path is not empty | ||
| // ErrRepositoryAlreadyExists is returned. | ||
| // ErrCloneDirNotEmpty is returned. |
There was a problem hiding this comment.
I'd keep the existing error, as that more closely aligns with upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #1156
Opening as a draft PR to see whether or not the cleanup logic is necessary.
I recycled the cleanup function into an empty dir check to prevent unwanted file deletions on error, but I think an early error would allow the cleanup logic to stay in place without interfering with a user's expectations if we want to keep it.