Support building with GopherJS #360
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d84485b to
5904ad7
Compare
Signed-off-by: Christian Stewart <christian@paral.in>
Adds a separate build file for wasm and gopherjs environments. Issues filed relating to no "gopherjs" tag being set - requiring the more awkward "js,!wasm" condition, as well as the os.Ctime incompatibility: - gopherjs/gopherjs#1047 - gopherjs/gopherjs#1046 Now the "gopherjs build -v" command works in this repository. Signed-off-by: Christian Stewart <christian@paral.in>
5904ad7 to
b641fd8
Compare
|
Not stale |
Member
pjbgf
commented
Apr 8, 2024
<
8000
/div>
|
@paralin this PR needs a rebase. Is the first commit still needed? Please add tests to ensure this works (and to avoid future regression). |
|
I will rebase it. Not sure how to add test cases when the CI never runs the build with gopherjs nor with the gopherjs tag set. |
|
I am not currently as it does not yet support go1.20, go1.21, go1.22 However, there is effort underway to get it up to spec with go1.22 and once that completes I will test it & likely use it. If you want, we can close this for now and I'll reopen it if I use gopherjs again. |
|
@paralin thanks for the quick reply. Let's close it for now as we are due a bump out of Go1.19, and reopen once they support the latest Go versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds supports building with "gopherjs build."