8000 Fix ephemeral runner deletion (#34447) by NorthRealm · Pull Request #34513 · go-gitea/gitea · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix ephemeral runner deletion (#34447) #34513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

Fix ephemeral runner deletion (#34447) #34513

merged 1 commit into from
May 21, 2025

Conversation

NorthRealm
Copy link
Contributor

Backport #34447

@ChristopherHX @NorthRealm
Fix ephemeral runner deletion (#34447)
f3b9d5e 
* repository deletion, delete ephemeral runners with active tasks as
well skips regular cleanup
* user deletion, delete ephemeral runners with active tasks as well
skips regular cleanup
* delete ephemeral runners once status changes to done
* You no longer see used ephemeral runners after the task is done
  * if you see one the cron job takes care of it

(cherry picked from commit 73f640f)
@GiteaBot GiteaBot added this to the 1.24.0 milestone May 21, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 21, 2025
@NorthRealm NorthRealm marked this pull request as ready for review May 21, 2025 09:50
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 21, 2025
ChristopherHX
ChristopherHX approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor
@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NorthRealm :)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 21, 2025
@techknowlogick techknowlogick merged commit 038990e into go-gitea:release/v1.24 May 21, 2025
26 checks passed
@NorthRealm NorthRealm deleted the backport34447 branch May 22, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@ChristopherHX ChristopherHX ChristopherHX approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@NorthRealm @lunny @ChristopherHX @techknowlogick @GiteaBot
0