8000 Remove redundant quotes with IgnoreInlineComment=true · Issue #99 · go-ini/ini · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove redundant quotes with IgnoreInlineComment=true #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ziflex opened this issue Apr 22, 2017 · 2 comments
Closed

Remove redundant quotes with IgnoreInlineComment=true #99

ziflex opened this issue Apr 22, 2017 · 2 comments

Comments

@ziflex
Copy link
ziflex commented Apr 22, 2017

Hi there,

Finally, the lib can ignore inline comments. It's great and works like a charm. But can we now remove redundant quotes for values that contain ; or # symbols when IgnoreInlineComment is set to true?

Specifically, here

ini/ini.go

Line 502 in 1730955

} else if strings.ContainsAny(val, "#;") {

unknwon added a commit that referenced this issue May 18, 2017
@unknwon
ini: do not outout back quotes if IgnoreInlineComment enabled (#99)
36da989
@unknwon unknwon added the bug label May 18, 2017
@unknwon
Copy link
Member
unknwon commented May 18, 2017

Thanks for the report! Please update and try again!

@ziflex
Copy link
Author
ziflex commented May 18, 2017

Fixed, great! Thank you!

@ziflex ziflex closed this as completed May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ziflex @unknwon
0