8000 file: customize output delimiter by aligator · Pull Request #226 · go-ini/ini · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

file: customize output delimiter #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 7, 2020
Merged

file: customize output delimiter #226

merged 5 commits into from
Mar 7, 2020

Conversation

aligator
Copy link
Contributor
@aligator aligator commented Mar 7, 2020 •
edited
Loading

What problem should be fixed?

See #203

Have you added test cases to catch the problem?

I just added a test for the closed PR and also fixed a bug (the default delimiter was set to '' it should be '=')
I also renamed the configuration to KeyValueDelimiterOnWrite as you suggested.

@unknwon
Copy link
Member
unknwon commented Mar 7, 2020

Thanks!

@unknwon unknwon changed the title customization output delimiter file: customize output delimiter Mar 7, 2020
@unknwon unknwon merged commit 8e0f5b3 into go-ini:master Mar 7, 2020
@aligator aligator mentioned this pull request Mar 7, 2020
Closed
@aligator aligator deleted the outputDelimiter branch March 14, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unknwon unknwon unknwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aligator @unknwon @lasiar
0