Fix LDAP diagnostics message used as format string #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a couple of tests for the `GetLDAPError()` function.
The GetLDAPError()-function passes the `diagnosticMessage` error field as the first parameter to `fmt.Errorf()`. If this message happens to contain a `%`-character, Go will try to interpret it. This doesn't directly lead to an error, but results in error messages containing format string error codes. E.g.: The error message "Detailed error message %" will result in the error "Detailed error message %!(NOVERB)". This patch fixes this by inserting a format string as the first argument to `fmt.Errorf()`.
johnweldon
approved these changes
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetLDAPError()-function passes thediagnosticMessageerror field as the first parameter tofmt.Errorf(). If this message happens to contain a%-character, Go will try to interpret it.This pull request fixes this by adding a format string as the first argument to
fmt.Errorf().It also adds a couple of tests for the
GetLDAPError()-function.