8000 add modify-increment extension support detailed in RFC4525 by jamesgoodhouse · Pull Request #227 · go-ldap/ldap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add modify-increment extension support detailed in RFC4525 #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 10, 2019
Merged

add modify-increment extension support detailed in RFC4525 #227

merged 4 commits into from
Dec 10, 2019

Conversation

jamesgoodhouse
Copy link
Contributor

This extension is detailed in RFC4525.
To summarize, it allows for auto-incrementing a specific attribute by a
specific amount. It can be used in conjunction with pre-read, post-read,
and assert control types

@jamesgoodhouse
add modify-increment extension support detailed in RFC4525
101e349 
This extension is detailed in [RFC4525](https://tools.ietf.org/html/rfc4525).
To summarize, it allows for auto-incrementing a specific attribute by a
specific amount. It can be used in conjunction with pre-read, post-read,
and assert control types
@jamesgoodhouse
Copy link
Contributor Author

Any thoughts on this @johnweldon?

johnweldon
johnweldon approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member
@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you!

johnweldon
johnweldon requested changes Dec 7, 2019
View reviewed changes
Copy link
Member
@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, can you also add the equivalent changes to the v3 branch.

We'll figure out a good way to appropriately share changes with this new go mod approach, but for now we need to make changes in both places I think.

@jamesgoodhouse
Copy link
Contributor Author

@johnweldon Done!

johnweldon
johnweldon approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member
@ 9E40 johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnweldon johnweldon merged commit 5c8e362 into go-ldap:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnweldon johnweldon johnweldon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesgoodhouse @johnweldon
0