Fix race condition in unit test #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## master #1664 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 38 38
Lines 7404 7404
=======================================
Hits 5939 5939
Misses 1002 1002
Partials 463 463Continue to review full report at Codecov.
|
casualjim
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes (again!) the t.Parallel() issue in schema validation unit tests.
The critical section which must be protected by locks is longer than initially thought,
because of package level cache in go-openapi/spec.
Signed-off-by: Frederic BIDON fredbi@yahoo.com