10000 feat: add sha512sum to checksum registry and add notices by 42atomys · Pull Request #59 · go-sprout/sprout · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add sha512sum to checksum registry and add notices #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2024
Merged

feat: add sha512sum to checksum registry and add notices #59

merged 2 commits into from
Aug 19, 2024

Conversation

42atomys
Copy link
Member

Description

Introduce the sha512Sum function as requested by sprig community and update old functions to new standards (naming convention and notice for deprecation) to checksum registry

Changes

  • Add sha512Sum function to checksum registry
  • Add error return to each method of the registry
  • Add notice to deprecate old naming sha1sum -> sha1Sum

Duplicate of Masterminds/sprig#400, Masterminds/sprig#326

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • This change requires a change to the documentation on the website.

Additional Information

Documentation update are embed

@42atomys 42atomys added good first issue Good for newcomers priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously type/feature ⭐ Addition of new feature aspect/dex 🤖 Concerns developers' experience with the codebase state/done ✔ This is done! labels Aug 19, 2024
@42atomys 42atomys added this to the v1.0 milestone Aug 19, 2024
@42atomys 42atomys self-assigned this Aug 19, 2024
@42atomys 42atomys merged commit 13fe589 into main Aug 19, 2024
18 checks passed
@42atomys 42atomys deleted the feat/checksum-sha512-and-tweaks branch August 19, 2024 15:17
@codecov Codecov
Copy link
codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
registry/checksum/checksum.go 92.3% <100.0%> (+7.6%) ⬆️
registry/checksum/functions.go 100.0% <100.0%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@42atomys 42atomys

Labels
aspect/dex 🤖 Concerns developers' experience with the codebase domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously good first issue Good for newcomers priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed state/done ✔ This is done! type/feature ⭐ Addition of new feature
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@42atomys
0