Add support for multi-line double-quoted strings with CRLF line endings #744
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
+ Coverage 77.83% 77.86% +0.03%
==========================================
Files 22 22
Lines 8056 8067 +11
==========================================
+ Hits 6270 6281 +11
Misses 1370 1370
Partials 416 416 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Adds support for multi-line double-quoted YAML strings with CRLF line endings
- Handles
\r(and optional\n) inscanDoubleQuoteto treat CRLF as a newline - Adds decoder tests for line continuations using LF, CRLF, and CR
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scanner/scanner.go | Handle \r in scanDoubleQuote, skip following \n in CRLF pairs |
| decode_test.go | Add tests for multi-line continuations with LF, CRLF, and lone CR |
| s.progressLine(ctx) | ||
| progress = 1 | ||
| // Skip \n after \r in CRLF sequences | ||
| if idx+2 < size && src[idx+2] == '\n' { |
There was a problem hiding this comment.
Off-by-one check: when at a '\r' at src[idx], the '\n' to skip is at src[idx+1], not src[idx+2]. Update the condition to if idx+1 < size && src[idx+1] == '\n'.
| if idx+2 < size && src[idx+2] == '\n' { | |
| if idx+1 < size && src[idx+1] == '\n' { |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
This is not true. We have to check src[idx+2].
src[idx]=\src[idx+1]=\rsrc[idx+2]=\n
|
LGTM 👍 |
Closes #736
Before submitting your PR, please confirm the following.