Add indentation to flow values on new lines #759
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds proper indentation for flow values on new lines and verifies the behavior via extended test cases.
- New test cases in parser_test.go validate correct handling of flow-style mappings and sequences, including inline comments.
- Updates in ast/ast.go adjust flow-style value indentation logic for both mapping and sequence nodes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| parser/parser_test.go | Added multiple test cases to check flow-style indentation on new lines with comments. |
| ast/ast.go | Updated indentation logic for flow-style mapping and sequence nodes for accurate formatting output. |
| @@ -1450,16 +1450,25 @@ func (n *MappingValueNode) toString() string { | |||
| } | |||
| return fmt.Sprintf("%s%s: %s", space, n.Key.String(), value) | |||
| } else if keyIndentLevel < valueIndentLevel && !n.IsFlowStyle { | |||
| valueStr := n.Value.String() | |||
| 8000 | // For flow-style values indented on the next line, we need to add the proper indentation | ||
| if m, ok := n.Value.(*MappingNode); ok && m.IsFlowStyle { | |||
There was a problem hiding this comment.
The logic handling flow-style indentation for MappingNode and SequenceNode is almost identical. Consider refactoring this duplicated logic into a dedicated helper function to improve maintainability.
Copilot uses AI. Check for mistakes.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #759 +/- ##
=======================================
Coverage 77.97% 77.97%
=======================================
Files 22 22
Lines 8108 8108
=======================================
Hits 6322 6322
Misses 1370 1370
Partials 416 416 🚀 New features to boost your workflow:
|
Closes #694
Add the proper indentations to flow values on new lines. Thanks for the review!
Before submitting your PR, please confirm the following.