Use golang.org/x/term in checkIfTerminal #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c5621c to
5b9cc35
Compare
|
Friendly ping @markbates |
The terminal functionality was moved from golang.org/x/crypto/ssh/terminal to golang.org/x/term and the former package now just wraps the latter (see golang/crypto@4be66e5). Thus, avoid pulling in golang.org/x/crypto and depend on golang.org/x/term directly.
61826a9 to
3e5117d
Compare
|
Friendly ping @paganotoni |
|
This looks good to me. Merging it. Thanks @tklauser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terminal functionality was moved from
golang.org/x/crypto/ssh/terminaltogolang.org/x/termand the formerpackage now just wraps the latter (see golang/crypto@4be66e5). Thus,
avoid pulling in
golang.org/x/cryptoand depend ongolang.org/x/termdirectly.