Allow passing Query-Options and SubOptions for Queries in ArangoDB Datsource #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Closes ArangoDB FullCount option for pagination support #1545
- We introduce options to add different variety of optional qury Options and Query SubOptions in ArangoDB Database.
Umang01-hash
approved these changes
May 15, 2025
Umang01-hash
added a commit
that referenced
this pull request
May 15, 2025
* Bump the go_modules group across 6 directories with 2 updates (#1702) * Bump the go_modules group across 6 directories with 2 updates Bumps the go_modules group with 1 update in the /examples/using-add-filestore directory: [golang.org/x/net](https://github.com/golang/net). Bumps the go_modules group with 1 update in the /pkg/gofr/datasource/arangodb directory: [golang.org/x/net](https://github.com/golang/net). Bumps the go_modules group with 1 update in the /pkg/gofr/datasource/dgraph directory: [golang.org/x/net](https://github.com/golang/net). Bumps the go_modules group with 1 update in the /pkg/gofr/datasource/kv-store/badger directory: [golang.org/x/net](https://github.com/golang/net). Bumps the go_modules group with 1 update in the /pkg/gofr/datasource/pubsub/eventhub directory: [golang.org/x/net](https://github.com/golang/net). Bumps the go_modules group with 1 update in the /pkg/gofr/datasource/pubsub/nats directory: [github.com/nats-io/nats-server/v2](https://github.com/nats-io/nats-server). Updates `golang.org/x/net` from 0.36.0 to 0.38.0 - [Commits](golang/net@v0.36.0...v0.38.0) Updates `golang.org/x/net` from 0.36.0 to 0.38.0 - [Commits](golang/net@v0.36.0...v0.38.0) Updates `golang.org/x/net` from 0.36.0 to 0.38.0 - [Commits](golang/net@v0.36.0...v0.38.0) Updates `golang.org/x/net` from 0.36.0 to 0.38.0 - [Commits](golang/net@v0.36.0...v0.38.0) Updates `golang.org/x/net` from 0.36.0 to 0.38.0 - [Commits](golang/net@v0.36.0...v0.38.0) Updates `github.com/nats-io/nats-server/v2` from 2.10.21 to 2.10.27 - [Release notes](https://github.com/nats-io/nats-server/releases) - [Changelog](https://github.com/nats-io/nats-server/blob/main/.goreleaser.yml) - [Commits](nats-io/nats-server@v2.10.21...v2.10.27) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect dependency-group: go_modules - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect dependency-group: go_modules - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect dependency-group: go_modules - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect dependency-group: go_modules - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect dependency-group: go_modules - dependency-name: github.com/nats-io/nats-server/v2 dependency-version: 2.10.27 dependency-type: direct:production dependency-group: go_modules ... Signed-off-by: dependabot[bot] <support@github.com> * update mock interface for JetStream --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: umang01-hash <mundhraumang.02@gmail.com> * Fix/worfklow permissions (#1701) * Bump crate-ci/typos from 1.31.2 to 1.32.0 in the actions group (#1710) * Bump google.golang.org/api from 0.231.0 to 0.232.0 (#1709) * Migrate to golangci-lint v2 (#1708) * Use golangci-lint migration tool I simply launched the following command $ golangci-lint migrate The configuration file was updated to the new format. The comments were stripped by the migration tool. * Restore the comments stripped by golangci-lint migration tool I copy pasted them manually from the v1 configuration file. * Remove useless exclusions from golangci-lint Also fix "examples" folder exclusions. This folder was previously excluded by golangci-lint v1. The migration tool failed to migrate this. Later, we can remove the exclusions for "examples". But the idea is to keep the same behavior as before. * Remove legacy "lax" option from golangci-lint config We don't need it, we can use the default value. lax was the default behavior in the golangci-lint v1. We can remove it as we don't need it. * Add TODO comments for golangci-lint presets We may want to fix these errors reported by golangci-lint in the future. But as they were already in golangci-lint v1, we will not fix them now. * Remove some staticcheck rules from golangci-lint config These rules were not activated in golangci-lint v1. They were added in v2 by default, but they are reporting a lot of issues. This commit restores the previous behavior. We might want to re-enable them in the future, but for now. * Fix behavior of golangci-lint against Go comments These rules weren't not enabled in golangci-lint v1. Because we enabled EXC0014, the migration tool disabled the "comment" presets. So it removed all the exclusions about the Go comments. While we only expected to remove the EXC0014 exclusion. This commit restores the previous and expected behavior. We might want to re-enable them in the future, but for now. * Apply suggested fixes provided by latest testifylint version testifylint was improved, so it reports more issues now. These errors were fixed by simply running the following command: $ golangci-lint run --fix --enable-only testifylint * Fix errors reported by testifylint pkg/gofr/datasource/arangodb/arango_document_test.go:51:2: formatter: using msgAndArgs with non-string first element (msg) causes panic (testifylint) require.ErrorIs(t, err, errDocumentNotFound, err, "Expected error when document not found") ^ pkg/gofr/datasource/arangodb/arango_document_test.go:87:2: formatter: using msgAndArgs with non-string first element (msg) causes panic (testifylint) require.ErrorIs(t, err, errDocumentNotFound, err, "Expected error when document not found") * Apply suggested fixes provided by latest gci version gci was improved, so it reports more issues now. These errors were fixed by simply running the following command: $ golangci-lint fmt --fix * Migrate GitHub Actions to use golangci-lint v2 --------- Co-authored-by: Umang Mundhra <mundhraumang.02@gmail.com> * Add correlationID in user logs (#1696) * fix: disable logs for healthcheck endpoints (#1681) * Allow passing Query-Options and SubOptions for Queries in ArangoDB Datsource (#1711) * update version to v1.39.1 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ccoVeille <3875889+ccoVeille@users.noreply.github.com> Co-authored-by: Leonardo Biffi <leonardobiffi@outlook.com> Co-authored-by: Divya Darshana <98943137+coolwednesday@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.