Exhaust queued entries in previewChan prior to calling preview script #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And rename variable "path" to "prev"
|
@neeshy This is much better thank you. In the meantime I have been trying to get rid of redundant preview calls in movement commands when they don't change the current file. Hopefully I have not broken anything. It is possible to do this in find/search commands as well, but they are more complicated so maybe it's not worth for now. In general, image previews seem to be stable enough as we are not getting any issue reports about it. I think I might tag a new release soon so more people can give it a try. |
|
Excellent! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that ever since #546 when rapidly moving between a large amount of files, the
previewLoopthread can take a while to catch up to the currently selected file. It will try to clear and preview every file. It becomes especially apparent when previewing files over the network. This PR fixes that by avoiding redundant calls to the preview script. I've added logic to consume all available values inpreviewChanbefore a call to either the previewer or cleaner is made. Also, if""is sent over the channel immediately before a valid path,previewLoopwill still call the cleaner script and then the previewer script, just like before.