refactor: vhost and mappings infra impl & more #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the virtual host, mapping, and SSL infrastructure by updating repository interfaces, entities, and DTOs to support new domain requirements. Key changes include:
- Consolidation of query methods in the mapping repository and removal of redundant commands.
- Updates to the VirtualHost, SslPair, and Mapping entities to incorporate new fields such as primary/wildcard flags, creation timestamps, and marketplace information.
- Introduction of new and updated DTOs for virtual host operations, mappings retrieval, and service creation, along with enhancements to pagination handling.
Reviewed Changes
Copilot reviewed 121 out of 123 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/domain/repository/mappingQueryRepo.go | Updated interface methods for mapping queries. |
| src/domain/repository/mappingCmdRepo.go | Removed obsolete methods. |
| src/domain/entity/virtualHost.go | Added new fields for primary, wildcard, alias hostnames and created time. |
| src/domain/entity/sslPair.go and sslPair_test.go | Refactored SslPair signature to use a single main hostname instead of a slice. |
| src/domain/entity/mapping.go | Added marketplace fields and timestamps. |
| src/domain/dto/* | New and updated DTOs supporting virtual host and mapping operations. |
| CHANGELOG.md | Updated to reflect the new features and refactoring changes. |
Files not reviewed (2)
- .vscode/settings.json: Language not supported
- container/nginx/root/nginx.conf: Language not supported
Comments suppressed due to low confidence (1)
src/domain/entity/virtualHost.go:12
- [nitpick] Consider renaming 'AliasesHostnames' to 'aliasHostnames' to improve clarity and consistency with typical naming conventions.
AliasesHostnames []valueObject.Fqdn `json:"aliasesHostnames"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.