8000 Exclude some imports so clitable will work on windows by ktbyers · Pull Request #82 · google/textfsm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Exclude some imports so clitable will work on windows #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2021

Conversation

ktbyers
Copy link
Contributor
@ktbyers ktbyers commented May 6, 2020

ntc-templates and Netmiko both use clitable, but the import of terminal.py (via texttable.py) breaks support on windows (even though there is no code in terminal.py that needs executed given what we are doing).

So this fixes this behavior.

This improves on the PR in:

#68

Where fcntl was moved to the try/except.

@ktbyers
Copy link
Contributor Author
ktbyers commented May 6, 2020

This change:

      if token == '':

is because Python now generates a syntax warning on the previous code.

@PseudotsugaMenziesii
Copy link

@ktbyers you are my hero! I was just beating my head against a wall helping a coworker install and use Napalm only to hit this wall. Looks like I'll be manually adding a try/except block to terminal.py for the time being. That said, I will still use this as an excuse to have my employer support Linux workstations...

@ktbyers
Copy link
Contributor Author
ktbyers commented Sep 15, 2020

@harro Any possibility of including this PR and cutting a new release?

This issue causes a lot of pain in upstream libraries that use TextFSM including: NAPALM, ntc-templates, juniper pyez, and Nornir.

Regards, Kirk

@b-marcum
Copy link
b-marcum commented Oct 2, 2020

Google, please merge!

@mjbear
Copy link
mjbear commented Dec 26, 2020

Google, please merge!

Agreed.
It indeed does affect several upstream projects/libraries that utilize TextFSM.

Thank you!
-Mike

@harro harro self-requested a review May 27, 2021 05:42
@harro harro merged commit c922704 into google:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0