8000 document wire.Struct first argument by shantuo · Pull Request #197 · google/wire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

10000 document wire.Struct first argument #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2019
Merged

document wire.Struct first argument #197

merged 2 commits into from
Jun 18, 2019

Conversation

shantuo
Copy link
Contributor
@shantuo shantuo commented Jun 17, 2019

Fixes #196

@shantuo shantuo requested a review from zombiezen June 17, 2019 17:45
@go-cloud-bot
Copy link
go-cloud-bot bot commented Jun 17, 2019

Please edit the title of this pull request with the name of the affected component, or "all", followed by a colon, followed by a short summary of the change.

@googlebot googlebot added the cla: yes Google CLA has been signed! label Jun 17, 2019
zombiezen
zombiezen approved these changes Jun 17, 2019
View reviewed changes
Copy link
Collaborator
@zombiezen zombiezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after suggestions

@shantuo shantuo merged commit 89cb901 into google:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombiezen zombiezen zombiezen approved these changes

Assignees

@zombiezen zombiezen

Labels
cla: yes Google CLA has been signed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document wire.Struct's first argument form
3 participants
@shantuo @zombiezen @googlebot
0