[xls][mlir} Fix bug -array-to-bits related to xls.dynamic_bit_slice.
#2517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
9a64741 to
dc21d4e
Compare
This CL fixes a bug that occurred in the `-array-to-bits` pass during the legalization of `xls.array_slice`, which produced an incorrect `start` value for the resulting `xls.dynamic_bit_slice` op. The wrong computation comes from the fact that XLS uses left-to-right offsets for `array`s, including the original `xls.array_slice` op, but right-to-left offsets for `bits`, including the created `xls.dynamic_bit_slice`. The previous legalization pattern ignored the direction change during rewriting, so the fix consists of converting the left-to-right offset into a right-to-left offset. The CL also adds missing punctuation in an unrelated file and adds the `ArithDialect` to the dependencies of the `-array-to-bits` pass because this and other patterns may create ops from that dialect. PiperOrigin-RevId: 777914087
dc21d4e to
e507833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xls][mlir} Fix bug
-array-to-bitsrelated toxls.dynamic_bit_slice.This CL fixes a bug that occurred in the
-array-to-bitspass during the legalization ofxls.array_slice, which produced an incorrectstartvalue for the resultingxls.dynamic_bit_sliceop. The wrong computation comes from the fact that XLS uses left-to-right offsets forarrays, including the originalxls.array_sliceop, but right-to-left offsets forbits, including the createdxls.dynamic_bit_slice. The previous legalization pattern ignored the direction change during rewriting, so the fix consists of converting the left-to-right offset into a right-to-left offset.The CL also adds missing punctuation in an unrelated file and adds the
ArithDialectto the dependencies of the-array-to-bitspass because this and other patterns may create ops from that dialect.