8000 Auto generate dslx test cases for counter examples given by prove quickcheck main by abhinav-gothwal-007 · Pull Request #2543 · google/xls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Auto generate dslx test cases for counter examples given by prove quickcheck main #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Auto generate dslx test cases for counter examples given by prove quickcheck main #2543

wants to merge 1 commit into from
+146 −109

Conversation

abhinav-gothwal-007
8000 Copy link
@abhinav-gothwal-007 abhinav-gothwal-007 commented Jul 7, 2025 •
edited
Loading

Fixes #1574

@google-cla Google CLA
Copy link
google-cla bot commented Jul 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@abhinav-gothwal-007 abhinav-gothwal-007 marked this pull request as draft July 7, 2025 15:57
@abhinav-gothwal-007 abhinav-gothwal-007 marked this pull request as ready for review July 7, 2025 16:04
@proppy
Copy link
Member
proppy commented Jul 8, 2025

/cc @grebe and @cdleary who discussed before the idea of dumping counter examples as tests, see #1405

@proppy
Copy link
Member
proppy commented Jul 8, 2025

@abhinav-gothwal-007 I don't think that's related to #1574

proppy
proppy requested changes Jul 8, 2025
View reviewed changes
Copy link
Member
@proppy proppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make sure to format the files w/ the following clang-format configuration https://github.com/google/xls/blob/main/.clang-format ? that'll make the diff easier to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proppy proppy proppy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement] quickcheck constraints
2 participants
@abhinav-gothwal-007 @proppy
0