8000 feat: re-export `glob.globbySync` as `glob.sync` by bytemain · Pull Request #1135 · google/zx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: re-export glob.globbySync as glob.sync #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 16, 2025
Merged

feat: re-export glob.globbySync as glob.sync #1135

merged 11 commits into from
Mar 16, 2025

Conversation

bytemain
Copy link
Contributor
@bytemain bytemain commented Mar 16, 2025 •
edited
Loading

Fixes #1129

const packages = glob.sync(['package.json', 'packages/*/package.json']);
  • Tests pass
  • Appropriate changes to README are included in PR

@google-cla Google CLA
Copy link
google-cla bot commented Mar 16, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bytemain bytemain changed the title feat: reexport glob.sync feat: re-export glob.globbySync as glob.sync Mar 16, 2025
antongolub
antongolub requested changes Mar 16, 2025
View reviewed changes
antongolub
antongolub approved these changes Mar 16, 2025
View reviewed changes
Copy link
Collaborator
@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antongolub antongolub merged commit 9e2ce2e into google:main Mar 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antongolub antongolub antongolub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reexport glob.globbySync as glob.sync
2 participants
@bytemain @antongolub
0